Quantcast
Channel: WE MOVED to github.com/nuget. This site is not monitored!
Viewing all articles
Browse latest Browse all 7612

Commented Issue: Adding binding redirects removes comments, changes formatting. [1511]

$
0
0
Adding binding redirects removes any comments in the <assemblyBinding> sections, and also reformats the config file, changing whitespace in places unrelated to the binding redirects.

For example, this...

<runtime>
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
<!-- Required because Cclp.Presentation was built against a previous version -->
<dependentAssembly>
<assemblyIdentity name="Telerik.Windows.Data" publicKeyToken="5803cfa389c90ce7" culture="neutral"/>
<bindingRedirect oldVersion="2010.3.1314.35" newVersion="2011.1.419.35"/>
</dependentAssembly>
</assemblyBinding>
</runtime>

<startup>
<!-- Test comment -->
<supportedRuntime
version="v2.0.50727"/>
</startup>


...is changed to this...

<runtime>
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
<dependentAssembly>
<assemblyIdentity name="Telerik.Windows.Data" publicKeyToken="5803cfa389c90ce7" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-2011.1.419.35" newVersion="2011.1.419.35" />
</dependentAssembly>
</assemblyBinding>
</runtime>
<startup>
<!-- Test comment -->
<supportedRuntime version="v2.0.50727" />
</startup>

Note that:

1) The comment in the <assemblyBinding> section was removed (although the one in the <startup> section was not).
2) The newline between the <runtime> section and the <startup> section was removed.
3) A space was added before the self-closing bracket in the <supportedRuntime> element of the <startup> section.

Removing the comment is destroying important content. The whitespace changes are merely annoying, but it is very important to minimize unnecessary changes when using source control.
Comments: I think this is more than low impact, it causes too much pain with code reviews.

Viewing all articles
Browse latest Browse all 7612

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>