i feel it could be initially little confusing for few users who use to always find a package while searching for it (in the aggregated feed). Now with the change "Do not select the All source by default when opening dialog" when they don't find it in the Nodes[1] feed (which could be a local feed), they will have to click on the 'All' node and search for it.
Another approach to fix the perf problem addressed by this fix I can think of is:
1. When dialog loads, 'All' is selected be default
2. No results are displayed in the list, a message is shown to the user to either search for the package or click on a button to load the aggregated feed.
from @dotnetjunky: This is not doable with the dialog model.
Good point about search though. I think for 2.8, we can remember the selected node, similar to how we remember the tab. The default is the first node after All node. If user switches back to All, it will be remember the next time. I think it's a good tradeoff.
Another approach to fix the perf problem addressed by this fix I can think of is:
1. When dialog loads, 'All' is selected be default
2. No results are displayed in the list, a message is shown to the user to either search for the package or click on a button to load the aggregated feed.
from @dotnetjunky: This is not doable with the dialog model.
Good point about search though. I think for 2.8, we can remember the selected node, similar to how we remember the tab. The default is the first node after All node. If user switches back to All, it will be remember the next time. I think it's a good tradeoff.